Reporting dead links on the new open EPER.

[Biz]

Afternoon all,
Who is the 'main person(s)' to contact regarding the new open EPER?
I am in the midst of working out what parts I have for my Fiat Uno Turbo's and some diagrams links are dead.
It's fantastic work and I really appreciate it being done. I work with software engineers so I do know the pain of software sometimes (especially those cheeky little spaces!) Cheers!

 

[ben]

Post a couple here and I'll check if it's the server or code issue

 

[Biz]

https://eper.fiatforum.com/en/Drawings/Detail/F/F/UNO/MT/555/10/0/0/SubSubGroup

 

[ben]

And sorry, also the page where that is linked from.

 

[Biz]

HOME
FIAT
UNO
MT UNO TURBO R/89 (1989-1993)
555 APPARATUS AND ELECTRIC CONTROLS

APPARATUS AND ELECTRIC CONTROLS

FIAT UNO TURBO R/89 (1989-1993)

eper.fiatforum.com

 

[Wiltshire Chris]

Hello, good job on finding a bug and reporting it in a way that is easy for me to recreate, thank you.

It's a bug in the openPer code where we don't handle the case where the database has a NULL in the quantity field for a parts list.
@ben there's two ways to fix it, either tweak the code to handle NULLs correctly for quantity or change the data for the 594 rows (out of 1.6 million total rows so there aren't that may with an issue) that have a NULL in the database with a piece of SQL to set them to an empty string

UPDATE TBDATA SET TBD_QTY = '' WHERE TBD_QTY IS NULL

I tried the data update and that now works in my local version. The code fix is the 'purer' way of doing it but the data overwrite is probably more pragmatic. If you're happy to do the data overwrite then I'll fade back into the background and leave you to it, but if you want the code fixed then I'll sort that out in github.

 

[ben]

Hello, good job on finding a bug and reporting it in a way that is easy for me to recreate, thank you.

It's a bug in the openPer code where we don't handle the case where the database has a NULL in the quantity field for a parts list.
@ben there's two ways to fix it, either tweak the code to handle NULLs correctly for quantity or change the data for the 594 rows (out of 1.6 million total rows so there aren't that may with an issue) that have a NULL in the database with a piece of SQL to set them to an empty string



I tried the data update and that now works in my local version. The code fix is the 'purer' way of doing it but the data overwrite is probably more pragmatic. If you're happy to do the data overwrite then I'll fade back into the background and leave you to it, but if you want the code fixed then I'll sort that out in github.

Thanks @Wiltshire Chris - I've done the SQL update and it did indeed solve it.

 

[Biz]

Cheers guys appreciate it!